Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
Skins
  • Light
  • Brite
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Logo that says

Flow Battery Research Collective

  1. Home
  2. General Discussion
  3. MyStat control software refactor

MyStat control software refactor

Scheduled Pinned Locked Moved General Discussion
2 Posts 2 Posters 50 Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • sepiS Offline
    sepiS Offline
    sepi
    wrote last edited by sepi
    #1

    I have still not been able to test my cell because I wanted to make sure I had my mystat calibrated correctly. For this I wanted to implement a calibration wizard. Unfortunately I was not prepared to deal with the very large single file, single layer codebase of the mystat control software. I therefore had to start refactoring this code. My progress is visible here: https://codeberg.org/sepi/mystat/src/branch/feat-refactor-modular

    The advantages of my refactor are amongst others the following:

    • less global state, easier to understand code
    • multiple smaller modules making it easier to find code
    • layered architecture, separating concerns more cleanly
    • "plugin" system for easier extension
    • easier testing of both hardware code and gui code due to decoupling into layers. A mock hardware class could be implemented to test the gui or other Tabd could be implemented as new classes
    • availability of decoupled hardware layer that can be used independently of the gui
    • easier implementation of new "Tab plugins" by subclassing and using the hardware and gui layer.

    This is still work in progress and probably pretty buggy. I tried not to touch any of the implemented logic but there afe surely some problems left. Once I'm done with the refactor, I would like to write a wizard for calibration hoping to make it obsolete to consult the original paper for reference.

    I'm open for comments and suggestions now and help with testing once my branch has stabilised a bit.

    1 Reply Last reply
    1
    • kirkK Offline
      kirkK Offline
      kirk
      wrote last edited by
      #2

      This is great sepi! A calibration wizard would be excellent, thanks for taking this on. I cloned your repo and was able to launch it on my PC, happy to help test in the future!

      1 Reply Last reply
      0
      Reply
      • Reply as topic
      Log in to reply
      • Oldest to Newest
      • Newest to Oldest
      • Most Votes


      1

      Online

      69

      Users

      48

      Topics

      559

      Posts
      • Login

      • Don't have an account? Register

      • Login or register to search.
      Powered by NodeBB Contributors
      • First post
        Last post
      0
      • Categories
      • Recent
      • Tags
      • Popular
      • Users
      • Groups